https://bugzilla.redhat.com/show_bug.cgi?id=2050682 --- Comment #3 from Emmanuel Seyman <emmanuel@xxxxxxxxx> --- Sorry, I clean forgot about this review. Everything in the last spec looks ok, with three exceptions: a) I really don't think "LemonLDAP-NG WebSSO" makes a good summary for Fedora users. Something like "Web Single Sign On (SSO) and Access Management" would work much better. b) At one point, you make vim the default editor. Why do you do this? c) Building the package in mock and running rpmlint on the resulting binairies gives quite a lot of errors (mostly "files-duplicate" warnings in lemonldap-ng-doc.noarch). Please consider fixing this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2050682 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
