Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-MRO-Compat - Mro::* interface compatibility for Perls < 5.9.5 Alias: perl-MRO-Compat https://bugzilla.redhat.com/show_bug.cgi?id=411491 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-12-06 02:10 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 43ef6e27ad3a0c0e119a2a515110b464 MRO-Compat-0.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/01use.t t/02pod.t t/03pod_coverage.t t/10basic.t t/15pkg_gen.t t/20mros.t t/01use.............ok t/02pod.............ok t/03pod_coverage....ok t/10basic...........ok t/15pkg_gen.........ok t/20mros............ok All tests successful. Files=6, Tests=26, 1 wallclock secs ( 0.31 cusr + 0.06 csys = 0.37 CPU) + Package perl-MRO-Compat-0.05-4.fc9 -> Provides: perl(MRO::Compat) = 0.05 Requires: perl >= 0:5.006_000 perl(:MODULE_COMPAT_5.8.8) perl(Class::C3) >= 0.19 perl(strict) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review