https://bugzilla.redhat.com/show_bug.cgi?id=2068241 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- > TODO: Remove a trailing slash from URL tag. Ok. > FIX: If pgopogl.h is is built in, then GPL+ part of the binary License tag must be GPLv2+. Ok. > FATAL: SGI Free Software License B 1.1 is forbidden in Fedora. You need to remove this file from a source tarball. Ok. > FIX: Build-require libX11-devel (Makefile.PL:516). Ok. > FIX: Build-require make (perl-OpenGL-GLUT.spec:59). Ok. > FIX: Don't build-require perl(constant). It's only used from test.pl which you named and don't execute. Ok. > TODO: I believe perl(OpenGL) is not used at run-time by this package. Also because you do not execute test.pl, it's also not build-required. I think the dependency can be removed from run-time too. $ rpmlint perl-OpenGL-GLUT.spec ../SRPMS/perl-OpenGL-GLUT-0.72-1.fc37.src.rpm ../RPMS/x86_64/perl-OpenGL-GLUT-0.72-1.fc37.x86_64.rpm (none): W: unable to load spellchecking dictionary for en_US. (none): W: unable to load spellchecking dictionary for en_US. (none): W: unable to load spellchecking dictionary for en_US. (none): W: unable to load spellchecking dictionary for en_US. ======================================== rpmlint session starts ======================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-OpenGL-GLUT.src: W: strange-permission repackage.sh 775 perl-OpenGL-GLUT.x86_64: E: non-executable-script /usr/lib64/perl5/vendor_perl/OpenGL/demo.pl 644 /usr/bin/perl -w perl-OpenGL-GLUT.spec: W: invalid-url Source0: OpenGL-GLUT-0.72_repackaged.tar.gz perl-OpenGL-GLUT.spec: W: invalid-url Source0: OpenGL-GLUT-0.72_repackaged.tar.gz ========= 2 packages and 1 specfiles checked; 1 errors, 3 warnings, 1 badness; has taken 3.0 s ======== FIX: The renamed test.pl to demo.pl is now installed as /usr/lib64/perl5/vendor_perl/OpenGL/demo.pl. Either edit Makefile.PL to exclude it, or use a different file extension which is not autopicked by EU::MM. $ rpm -q -lv -p ../RPMS/x86_64/perl-OpenGL-GLUT-0.72-1.fc37.x86_64.rpm drwxr-xr-x 2 root root 0 Mar 28 15:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Mar 28 15:00 /usr/lib/.build-id/26 lrwxrwxrwx 1 root root 64 Mar 28 15:00 /usr/lib/.build-id/26/33f91a99734db8dc848900a47c38b437c12ee0 -> ../../../../usr/lib64/perl5/vendor_perl/auto/OpenGL/GLUT/GLUT.so drwxr-xr-x 2 root root 0 Mar 28 14:59 /usr/lib64/perl5/vendor_perl/OpenGL -rw-r--r-- 1 root root 19228 Jan 9 21:38 /usr/lib64/perl5/vendor_perl/OpenGL/GLUT.pm -rw-r--r-- 1 root root 40842 Jan 9 21:28 /usr/lib64/perl5/vendor_perl/OpenGL/demo.pl -rw-r--r-- 1 root root 768 Jan 9 16:56 /usr/lib64/perl5/vendor_perl/OpenGL/menutest.pl drwxr-xr-x 2 root root 0 Mar 28 14:59 /usr/lib64/perl5/vendor_perl/auto/OpenGL drwxr-xr-x 2 root root 0 Mar 28 14:59 /usr/lib64/perl5/vendor_perl/auto/OpenGL/GLUT -rwxr-xr-x 1 root root 145392 Mar 28 14:59 /usr/lib64/perl5/vendor_perl/auto/OpenGL/GLUT/GLUT.so drwxr-xr-x 2 root root 0 Mar 28 15:00 /usr/share/doc/perl-OpenGL-GLUT -rw-r--r-- 1 root root 143 Jan 9 21:38 /usr/share/doc/perl-OpenGL-GLUT/Changes -rw-r--r-- 1 root root 424 Jan 9 16:56 /usr/share/doc/perl-OpenGL-GLUT/README.md -rw-r--r-- 1 root root 40842 Jan 9 21:28 /usr/share/doc/perl-OpenGL-GLUT/demo.pl -rw-r--r-- 1 root root 768 Jan 9 16:56 /usr/share/doc/perl-OpenGL-GLUT/menutest.pl drwxr-xr-x 2 root root 0 Mar 28 15:00 /usr/share/licenses/perl-OpenGL-GLUT -rw-r--r-- 1 root root 3415 Jan 9 16:56 /usr/share/licenses/perl-OpenGL-GLUT/COPYRIGHT -rw-r--r-- 1 root root 2820 Mar 28 14:59 /usr/share/man/man3/OpenGL::GLUT.3pm.gz FIX: Remove demo.pl and menutest.pl from /usr/lib64/perl5/vendor_perl/OpenGL/. $ rpm -q --requires -p ../RPMS/x86_64/perl-OpenGL-GLUT-0.72-1.fc37.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libGL.so.1()(64bit) 1 libglut.so.3()(64bit) 1 libperl.so.5.34()(64bit) 1 perl(:MODULE_COMPAT_5.34.1) 1 perl(Carp) 1 perl(DynaLoader) 1 perl(Exporter) 1 perl(OpenGL) >= 0.70 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) TODO: Remove 'perl(OpenGL) >= 0.70'. $ rpm -q --provides -p ../RPMS/x86_64/perl-OpenGL-GLUT-0.72-1.fc37.x86_64.rpm | sort -f | uniq -c 1 perl(OpenGL::GLUT) = 0.72 1 perl-OpenGL-GLUT = 0.72-1.fc37 1 perl-OpenGL-GLUT(x86-64) = 0.72-1.fc37 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-OpenGL-GLUT-0.72-1.fc37.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in F37 (https://koji.fedoraproject.org/koji/taskinfo?taskID=84835191). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX items and consider fixing the TODO items before building this package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2068241 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
