https://bugzilla.redhat.com/show_bug.cgi?id=2068241 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. TODO: Remove a trailing slash from URL tag. Source archive (SHA-512: ade45f62e83ea279f9dabc03fa802cd401577a04f708293d829ca8a4b7fd5369579a010a018e45fce0d472e70b725222301f242bc48cf859c8a8430e68f43149) is original. Ok. Summary verified from lib/OpenGL/GLUT.pm. Ok. Description verified from lib/OpenGL/GLUT.pm. Ok. TODO: Licenses found, document them with a comment in the spec file: pgopogl.h is LGPLv2+ include/GL is MIT include/GL/glprocs.h is "SGI Free Software License B 1.1" FIX: If pgopogl.h is is built in, then GPL+ part of the binary License tag must be GPLv2+. FATAL: SGI Free Software License B 1.1 is forbidden in Fedora. You need to remove this file from a source tarball. FIX: Build-require libX11-devel (Makefile.PL:516). FIX: Build-require make (perl-OpenGL-GLUT.spec:59). FIX: Don't build-require perl(constant). It's only used from test.pl which you named and don't execute. TODO: I believe perl(OpenGL) is not used at run-time by this package. Also because you do not execute test.pl, it's also not build-required. All tests pass. Ok. I will resume with this review once you resolve the license of include/GL/glprocs.h. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2068241 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
