https://bugzilla.redhat.com/show_bug.cgi?id=2063554 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Did you not use rpmautospec on purpose, or did you get hit with it not being enabled by default due to a bug in rust2rpm 21-1? That issue should be fixed with rust2rpm 21-2. Feel free to regenerate the .spec file with rpmautospec before you import it to Fedora. You might also want to remove the "criterion" dev-dependency: - It's only used for compiling benchmarks (which we never do). - It pulls in lots of dependencies into your build, making it slower. - It and its dependencies take ages to compile, making your build slower. See here for an example how I usually handle this: https://src.fedoraproject.org/rpms/rust-httpdate/blob/rawhide/f/rust-httpdate.spec#_17 https://src.fedoraproject.org/rpms/rust-httpdate/blob/rawhide/f/httpdate-fix-metadata.diff You should also look into all the extraneous files that are shipped with the crate, for example "gen.sh" and "test-conf" directory. They probably should not be shipped with the RPMs we build. You could exclude them with a Cargo.toml patch, or by using %exclude %{crate_instdir}/gen.sh %exclude %{crate_instdir}/test-conf/ in the %files list of the -devel subpackage. Other than that, package looks good. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2063554 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
