https://bugzilla.redhat.com/show_bug.cgi?id=2049301 Tomas Orsava <torsava@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ondaaak@xxxxxxxxx | |) --- Comment #2 from Tomas Orsava <torsava@xxxxxxxxxx> --- Hi Ondřej! Here's first part of my review. So far it looks pretty good! Just a few nitpicks and things to sort out. Issues: ======= - Summary should not end with a fullstop/period - Remove not relevant comments from spec file: "Check if the automatically generated License and its spelling is correct for Fedora ..." - I don't really understand this comment (specifically the second line), could you rephrase it? " # argcomplete > 2 is already allowed upstream but the # patch touches also files not included in release tarball." - Source tarball in the SRPM file does not match the source tarball downloaded from the Source0 URL, why? - Have you tried reversing the order of the %pycached and %exclude macros in `%pycached %exclude %{python3_sitelib}/nox/tox_to_nox.py`? It would help readability, but I'm not sure if it'd actually work :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2049301 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
