https://bugzilla.redhat.com/show_bug.cgi?id=2042998 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Menšík <pemensik@xxxxxxxxxx> --- Well, man man citation: 8 System administration commands (usually only for root) I don't know how common it is in other distributions. If most often usage of that daemon is by the system, then I would expect it resides with similar services in /usr/sbin. It is not very important on Fedora, where also /sbin directory is added to default path. It seems man section is correct, but as a tool usually for administrators it should be in sbin. I think that daemon should also have its entries in %post and %postun from systemd-rpm-config, ensuring it is properly restarted on upgrades: BuildRequires: systemd-rpm-config ... %install ... %post tools %systemd_post %{name}-plugind.service %postun tools %systemd_postun_with_restart %{name}-plugind.service Unless it is required, service should run under its own non-privileged user. If its communication is lust local, it may be okay. Some options are described on [1]. Note SELinux strips even for root user systemd services ability to modify files of other users, where it does not have normal rights for modification. If that is required, it would need modification of selinux-policy. Otherwise it seems ready for inclusion. Thank you for working on it! 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2042998 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
