https://bugzilla.redhat.com/show_bug.cgi?id=2066040 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Packaging looks good to me, in theory. You can check out how the missing license file is handled in other packages, like here: https://src.fedoraproject.org/rpms/rust-libspa-sys/blob/rawhide/f/rust-libspa-sys.spec (You're already doing something very similar, but the "fetch from cargo" comment doesn't make any sense. If the published crate contains a LICENSE file, it is automatically included by rust2rpm, no need to "fetch" anything.) You might also want to use a rust2rpm config file like this one: https://src.fedoraproject.org/rpms/rust-pipewire-sys/blob/rawhide/f/.rust2rpm.conf (replace "pkgconfig(pipewire)" with "pkgconfig(libadwaita-1)", obviously) This will automatically insert the BuildRequires / Requires into the .spec file when you use rust2rpm. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2066040 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
