https://bugzilla.redhat.com/show_bug.cgi?id=2051874 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+ --- Comment #19 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- I think the dependency in initscripts is fine. initscripts is only installed optionally, and it's OK if it pulls in some other packages. -- After the removal of support for ifname= and the other fixes, this seems all OK. Quoting comment #1 above: Since this is using rust2rpm template, there isn't much to check. + package name is OK + license is acceptable for Fedora (GPLv3 and MIT) + license is specified correctly + latest version + R/P/BR look OK + fedora-review and rpmlint find no issues, except as noted above Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2051874 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
