[Bug 2053969] Review Request: gopass - The slightly more awesome standard unix password manager for teams

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2053969



--- Comment #5 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
As mentioned, the auxiliary commands are not required for gopass (not packaged
in the official binary release for example), so unless you've a good reason
they can be dropped. You should remove this parts of the spec:

> %build
> %gobuild -o %{gobuilddir}/bin/gopass %{goipath}
> for cmd in helpers/postrel pkg/pwgen/pwrules helpers/man helpers/changelog helpers/release; do
>   %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
> done

(...)

> install -m 0755 -vd                     %{buildroot}%{_bindir}
> install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/

(...)

> %files
> %license LICENSE
> %doc docs CONTRIBUTING.md GOVERNANCE.md README.md ARCHITECTURE.md CHANGELOG.md
> %{_bindir}/*


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux