https://bugzilla.redhat.com/show_bug.cgi?id=2031584 Maxwell G <gotmax@e.email> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #2 from Maxwell G <gotmax@e.email> --- > Patch0: locales-0.14.0-remove-broken-tests.patch > [...] > %patch0 -p1 Instead of completely deleting the test files, you should change `%gocheck` to `%gocheck -d eu`[1]. [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_running_the_unit_tests_gocheck > %files > %license LICENSE > %doc README.md This isn't necessary. Besides that, this package looks good to me. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2031584 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
