https://bugzilla.redhat.com/show_bug.cgi?id=2056663 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |mikel@xxxxxxxxxxxxxxx CC| |mikel@xxxxxxxxxxxxxxx Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value --- Comment #2 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- Hi Davide, The spec is correct. I've two comments: - Package could be named rom64 rather than golang-github-mroach-rom64. If you want to do so, rename the BZ, the spec and define goname as done for example in `doctl` package. - Package has no tests, so %check section could be removed, but I think it's better to keep it in case future releases have any test. Let me know if you decide to change the name or not and will approve later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2056663 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
