https://bugzilla.redhat.com/show_bug.cgi?id=2061077 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #9 from Jerry James <loganjerry@xxxxxxxxx> --- The license looks good, and the python object also looks correct now. However, with the latest srpm, I see this test failure: ``` ------------------------------------------------------------------------------- EdgePopulation::writeIndices ------------------------------------------------------------------------------- /builddir/build/BUILD/libsonata-0.1.11/tests/test_edges.cpp:83 ............................................................................... /builddir/build/BUILD/libsonata-0.1.11/tests/test_edges.cpp:91: FAILED: {Unknown expression after the reported line} due to unexpected exception with message: Unable to open file ./data/edges-no-index.h5.tmp (Virtual File Layer) Unable to lock file ``` I suspect that means that tests/data has to be copied to %{__cmake_builddir}/tests. I'm not worried about the hd5 warnings since, as you say, the tests pass anyway. A quick experiment showed that adding these lines to the other copies in %build leads to a successful run of the tests: mkdir -p %{__cmake_builddir}/tests cp -a tests/data %{__cmake_builddir}/tests So just add that and everything looks good. This package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2061077 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
