[Bug 2064142] Review Request: rust-twox-hash - Rust implementation of the XXHash and XXH3 algorithms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2064142

Mads Kiilerich <mads@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |mads@xxxxxxxxxxxxx



--- Comment #1 from Mads Kiilerich <mads@xxxxxxxxxxxxx> ---
I verified that the spec and source is exactly as generated with "rust2rpm -as
twox-hash", except

@@ -12,6 +12,9 @@
 License:        MIT
 URL:            https://crates.io/crates/twox-hash
 Source:         %{crates_source}
+# Address test failures on non-x86 platforms
+Patch0:        
https://github.com/shepmaster/twox-hash/pull/86.patch#/twox-hash-1.6.2-Support-big-endian-platforms.patch
+Patch1:        
https://github.com/shepmaster/twox-hash/pull/87.patch#/twox-hash-1.6.2-Fix-XXH3-generic-fallback.patch

 ExclusiveArch:  %{rust_arches}

@@ -58,18 +61,6 @@
 %files       -n %{name}+default-devel
 %ghost %{crate_instdir}/Cargo.toml

-%package     -n %{name}+digest-devel
-Summary:        %{summary}
-BuildArch:      noarch
-
-%description -n %{name}+digest-devel %{_description}
-
-This package contains library source intended for building other packages
which
-use the "digest" feature of the "%{crate}" crate.
-
-%files       -n %{name}+digest-devel
-%ghost %{crate_instdir}/Cargo.toml
-
 %package     -n %{name}+digest_0_10-devel
 Summary:        %{summary}
 BuildArch:      noarch

*Why are the main digest packages dropped? I think it deserves a comment in the
spec why the digests are dropped.*

The MIT license is OK.

The package builds locally on f35, installs, and works for enabling
experimental build of Mercurial with Rust extensions.

rpmlint is clean, except "W: no-documentation".


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2064142
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux