https://bugzilla.redhat.com/show_bug.cgi?id=2064155 Mads Kiilerich <mads@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |mads@xxxxxxxxxxxxx --- Comment #1 from Mads Kiilerich <mads@xxxxxxxxxxxxx> --- I verified that the spec and source is exactly as generated with "rust2rpm -as vcsgraph", except @@ -28,7 +28,6 @@ %description -n %{crate} %{_description} %files -n %{crate} -# FIXME: no license files detected %doc README.md %{_bindir}/analytics %{_bindir}/testing @@ -43,7 +42,6 @@ use the "%{crate}" crate. %files devel -# FIXME: no license files detected %doc %{crate_instdir}/README.md %{crate_instdir}/ @@ -88,17 +86,17 @@ %cargo_prep %generate_buildrequires -%cargo_generate_buildrequires +%cargo_generate_buildrequires -a %build -%cargo_build +%cargo_build -a %install -%cargo_install +%cargo_install -a %if %{with check} %check -%cargo_test +%cargo_test -a %endif %changelog I think the -a explanation should be a comment in the spec so the deviation from rust2rpm is obvious. While https://pagure.io/fedora-rust/rust2rpm/issue/110 might be the core problem, it would be nice to have a hint what -a does and why it is a valid workaround. It seems like it is an argument for cargo-inspector, but it is not clear to me what it changes from what default. The license file FIXME seems valid and points out an upstream problem - should it really just be removed like that? The GPLv2+ license is OK. The package builds locally on f35, installs, and works for enabling experimental build of Mercurial with Rust extensions. rpmlint is clean, except "W: no-documentation". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2064155 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
