Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libepc - Easy Publish and Consume library https://bugzilla.redhat.com/show_bug.cgi?id=410901 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-05 03:51 EST ------- * Dependency of libepc vs libepc-ui ! Not a blocker, however: [tasaka1@localhost libepc]$ rpm -q --requires libepc > a.txt [tasaka1@localhost libepc]$ rpm -q --requires libepc-ui > b.txt [tasaka1@localhost libepc]$ ( cat b.txt | while read f ; do if ! ( cat a.txt | grep -q "$f" ) ; then echo $f ; fi ; done ) | sed -e 's|=.*$||' | xargs rpm -q --whatprovides | sort | uniq atk-1.20.0-1.fc8 cairo-1.5.2-1.fc9 gtk2-2.12.2-1.fc9 libepc-0.3.0-1.fc9 libepc-ui-0.3.0-1.fc9 pango-1.19.0-1.fc9 This means that apart from libepc, libepc-ui requires only gtk2 (plus packages gtk2 depends on). - Is this what you actually expect? - Especially, does it make sense to split libepc-devel and libepi-ui-devel? * gnutls-devel dependency - While you write explicitly -------------------------------------------------------- BuildRequires: gnutls-devel -------------------------------------------------------- (libsoup-devel requires gnutls-devel) why don't you write "Requires: gnutls-devel" for libepc-devel? libepc-devel actually requires gnutls-devel by /usr/include/libepc-1.0/libepc/tls.h * timestamps - Please use --------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" --------------------------------------------------------- to keep timestamps on installed files (check the timestamps of installed header files, for example). While somethimes this does not work, this usually works for recent Makefiles. * libdir in .pc file on 64bits - (While I only have i386 machine) /usr/lib64/pkgconfig/libepc-1.0.pc contains the line --------------------------------------------------------- prefix=/usr exec_prefix=${prefix} libdir=${exec_prefix}/lib includedir=${prefix}/include --------------------------------------------------------- Here libdir is wrong (and perhaps same for libepc-ui-1.0.pc) * tests/ subdirectory - Maybe some test programs can be executed on %check? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review