https://bugzilla.redhat.com/show_bug.cgi?id=2059313 Paul Wouters <paul.wouters@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value --- Comment #2 from Paul Wouters <paul.wouters@xxxxxxxx> --- that's fair :) I try not to overuse macros, and only use it in case there is really a re-usable part to it, which in this case there is. I've updated the spec/srpm I sponsored you for your package, so once you have that going, perhaps you can run a full "fedora-review -b 2059313" on this and do a full review? :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2059313 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure