https://bugzilla.redhat.com/show_bug.cgi?id=2028899 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- You seem to have updated the spec file or SRPM, but not both, please reconcile those changes before importing the package: Diff spec file in url and in SRPM --------------------------------- --- /home/deca/Downloads/2028899-rust-tree-sitter-loader/srpm/rust-tree-sitter-loader.spec 2022-03-09 15:59:42.961643210 +0100 +++ /home/deca/Downloads/2028899-rust-tree-sitter-loader/srpm-unpacked/rust-tree-sitter-loader.spec 2022-02-23 07:55:08.000000000 +0100 @@ -14,5 +14,5 @@ URL: https://crates.io/crates/tree-sitter-loader Source: %{crates_source} -# Upstream license file - tree-sitter/tree-sitter#1520 +# Upstream license file Source1: https://github.com/tree-sitter/tree-sitter/raw/v%{version}/LICENSE#/LICENSE.upstream Other than that, looks good to me. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass (there are no tests) - latest compatible version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2028899 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
