[Bug 2061077] Review Request: libsonata - A Python and C++ interface to the SONATA format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2061077



--- Comment #6 from Jerry James <loganjerry@xxxxxxxxx> ---
I was annoyed that I didn't figure this out, so I just tried one more time. :-)
 The reference to report_reader.cpp line 463 is a red herring.  That's just the
optimizer cleverly combining paths to the assertion failure code.  The
assertion failure actually happens on line 473:

    std::copy(&buffer[gid_start], &buffer[gid_end], &data_ptr[offset]);

The problem is that gid_end can equal the size of buffer, and &buffer[gid_end]
triggers the assertion failure in that case.  The code should look like this
instead:

    std::copy(buffer.begin() + gid_start, buffer.begin() + gid_end,
&data_ptr[offset]);

With that change, all of the tests pass.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2061077
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux