https://bugzilla.redhat.com/show_bug.cgi?id=2012990 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra |needinfo?(mhayden@xxxxxxxxx |in.net) |m) --- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Dist tag is present. (OK: rpmautospec) - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1546240 bytes in 408 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation While some of the other packages in this tranche have been marginal, I think at this point you really should make a separate -doc subpackage. - You *could* go through some contortions to hardlink some of the duplicate files in the samples that rpmlint is complaining about with the “hardlink” command from the “hardlink” package. I think you would have to switch to manual installation of the %doc files, and the savings would be modest: $ hardlink -v samples/ Linking samples/snippets/requirements-test.txt to samples/v1beta1/requirements-test.txt (-14 B) Linking samples/quickstart/requirements.txt to samples/snippets/requirements.txt (-32 B) Linking samples/quickstart/requirements.txt to samples/v1beta1/requirements.txt (-32 B) Linking samples/quickstart/noxfile.py to samples/snippets/noxfile.py (-8.69 KiB) Linking samples/quickstart/noxfile.py to samples/v1beta1/noxfile.py (-8.69 KiB) Mode: real Files: 402 Linked: 5 files Compared: 0 xattrs Compared: 267 files Saved: 17.45 KiB Duration: 0.004412 seconds (I don’t recommend using “hardlink -t” in packaging, because we don’t want to discard timestamps.) I have used and recommended this technique where the number or size of duplicate files is large, but I don’t think this is worth it in practice for this package. Besides, I think rpmlint is mostly worried about accidental duplicates that might indicate a packaging error rather than files that really need to be the same. If you did hardlink these files, you would get just as many errors, only some of them would now be about cross-directory hardlinks, since rpmlint doesn’t understand that in this case the files in question are guaranteed to be on the same filesystem since the package owns their “lowest common parent” directory. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0", "*No copyright* [generated file]", "Apache License 2.0 [generated file]". 94 files have unknown license. Detailed output of licensecheck in /home/reviewer/2012990-python-google-cloud- datacatalog/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.10/site- packages/google(python3-google-cloud-os-config, python3-google-cloud- dns, python3-google-api-core, python3-google-cloud-core, python3-protobuf, python3-google-cloud-private-ca, python3-google- cloud-bigtable, python3-google-cloud-storage, python3-google-cloud- bigquery-datatransfer, python3-grpc-google-iam-v1, python3-google- cloud-asset, python3-google-cloud-access-context-manager, python3-google-resumable-media, python3-google-cloud-iam, python3-google-cloud-bigquery-reservation, python3-google-cloud- bigquery-connection, python3-google-cloud-access-approval, python3-google-cloud-spanner, python3-google-cloud-automl, python3-google-cloud-appengine-admin, python3-googleapis-common- protos, python3-google-cloud-bigquery-storage, python3-google-cloud- kms, python3-google-cloud-build, python3-google-cloud-firestore, python3-google-cloud-redis, python3-google-cloud-containeranalysis, python3-google-cloud-functions, python3-google-cloud-container, python3-google-cloud-api-gateway, python3-google-cloud-billing, python3-google-cloud-dms, python3-google-cloud-apigee-connect, python3-google-cloud-org-policy, python3-google-cloud-billing-budgets, python3-google-cloud-bigquery), /usr/lib/python3.10/site- packages/google/cloud(python3-google-cloud-os-config, python3-google- cloud-dns, python3-google-cloud-core, python3-google-cloud-private-ca, python3-google-cloud-bigtable, python3-google-cloud-storage, python3-google-cloud-bigquery-datatransfer, python3-google-cloud- asset, python3-google-cloud-iam, python3-google-cloud-bigquery- reservation, python3-google-cloud-bigquery-connection, python3-google- cloud-access-approval, python3-google-cloud-spanner, python3-google- cloud-automl, python3-google-cloud-appengine-admin, python3-googleapis-common-protos, python3-google-cloud-bigquery- storage, python3-google-cloud-kms, python3-google-cloud-build, python3-google-cloud-firestore, python3-google-cloud-redis, python3-google-cloud-containeranalysis, python3-google-cloud- functions, python3-google-cloud-container, python3-google-cloud-api- gateway, python3-google-cloud-billing, python3-google-cloud-dms, python3-google-cloud-apigee-connect, python3-google-cloud-org-policy, python3-google-cloud-billing-budgets, python3-google-cloud-bigquery) OK: appropriate co-ownership of python namespace package directories [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/googleapis/python-datacatalog/archive/v3.7.0/python-datacatalog-3.7.0.tar.gz : CHECKSUM(SHA256) this package : 8fd0fd24dfe38d93efcc62bd76ce9808f3a593a1fdce191e529d383849c197b6 CHECKSUM(SHA256) upstream package : 8fd0fd24dfe38d93efcc62bd76ce9808f3a593a1fdce191e529d383849c197b6 Requires -------- python3-google-cloud-datacatalog (rpmlib, GLIBC filtered): (python3.10dist(google-api-core) < 3~~dev0 with python3.10dist(google-api-core) >= 1.28) (python3.10dist(google-api-core[grpc]) < 3~~dev0 with python3.10dist(google-api-core[grpc]) >= 1.28) (python3.10dist(grpc-google-iam-v1) < 0.13~~dev0 with python3.10dist(grpc-google-iam-v1) >= 0.12.3) python(abi) python3.10dist(proto-plus) Provides -------- python3-google-cloud-datacatalog: python-google-cloud-datacatalog python3-google-cloud-datacatalog python3.10-google-cloud-datacatalog python3.10dist(google-cloud-datacatalog) python3dist(google-cloud-datacatalog) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2012990 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: fonts, Ocaml, SugarActivity, C/C++, R, Java, Perl, Haskell, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python-google-cloud-datacatalog.spec: W: patch-not-applied Patch0: python-google-cloud-datacatalog-mock.patch python3-google-cloud-datacatalog.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1beta1/py.typed /usr/lib/python3.10/site-packages/google/cloud/datacatalog/py.typed:/usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1/py.typed python3-google-cloud-datacatalog.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1beta1/services/__init__.py /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1/services/__init__.py python3-google-cloud-datacatalog.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1beta1/services/data_catalog/__init__.py /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1/services/data_catalog/__init__.py python3-google-cloud-datacatalog.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1beta1/services/data_catalog/transports/__init__.py /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1/services/data_catalog/transports/__init__.py python3-google-cloud-datacatalog.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1beta1/services/policy_tag_manager/__init__.py /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1/services/policy_tag_manager/__init__.py python3-google-cloud-datacatalog.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1beta1/services/policy_tag_manager/transports/__init__.py /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1/services/policy_tag_manager/transports/__init__.py python3-google-cloud-datacatalog.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1beta1/services/policy_tag_manager_serialization/__init__.py /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1/services/policy_tag_manager_serialization/__init__.py python3-google-cloud-datacatalog.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1beta1/services/policy_tag_manager_serialization/transports/__init__.py /usr/lib/python3.10/site-packages/google/cloud/datacatalog_v1/services/policy_tag_manager_serialization/transports/__init__.py python3-google-cloud-datacatalog.noarch: W: files-duplicate /usr/share/doc/python3-google-cloud-datacatalog/samples/v1beta1/noxfile.py /usr/share/doc/python3-google-cloud-datacatalog/samples/quickstart/noxfile.py:/usr/share/doc/python3-google-cloud-datacatalog/samples/snippets/noxfile.py python3-google-cloud-datacatalog.noarch: W: files-duplicate /usr/share/doc/python3-google-cloud-datacatalog/samples/v1beta1/requirements.txt /usr/share/doc/python3-google-cloud-datacatalog/samples/quickstart/requirements.txt:/usr/share/doc/python3-google-cloud-datacatalog/samples/snippets/requirements.txt python3-google-cloud-datacatalog.noarch: W: files-duplicate /usr/share/doc/python3-google-cloud-datacatalog/samples/v1beta1/requirements-test.txt /usr/share/doc/python3-google-cloud-datacatalog/samples/snippets/requirements-test.txt 2 packages and 0 specfiles checked; 0 errors, 12 warnings, 0 badness; has taken 0.7 s -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2012990 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
