https://bugzilla.redhat.com/show_bug.cgi?id=2060852 --- Comment #2 from Paul Howarth <paul@xxxxxxxxxxxx> --- (In reply to Xavier Bachelot from comment #1) > - I was about to write there was a missing comment above the patch but the > comment is above the line applying it. Not a big deal, but I'm used to see > such comment above the PatchX: line. I put it there because it feels more natural to me to put the comment at the point where the patch is applied rather than where it's declared. > - Use %make_build/%make_install That would normally go with use of ExtUtils::MakeMaker 6.76 but that's not available in EL-7 so I preferred to keep it this way so I could use the same spec everywhere. Once EL-7 goes EOL I'll probably update all of the packages I look after to use the new style. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2060852 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
