[Bug 2058411] Review Request: python-tcolorpy - Python library to apply true color for terminal text

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2058411



--- Comment #13 from Jonny Heggheim <hegjon@xxxxxxxxx> ---
(In reply to Miro Hrončok from comment #11)
> > Reported upstream: https://github.com/thombashi/tcolorpy/issues/2
> 
> You can send them a PR as well ;)

That is true, added one.

> > sed -i '1d' tcolorpy/__main__.py
> 
> This is very dangerous if you forget to remove it once they remove it.
> What about:
> 
> sed -i '1!b;/^#!/d' tcolorpy/__main__.py
> 
> Other than that, the package is APPROVED.

Thanks, I changed the sed command to use patch based on PR instead


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2058411
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux