https://bugzilla.redhat.com/show_bug.cgi?id=2045924 --- Comment #7 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Petr Menšík from comment #3) Thanks for the review. Moving step-by-step :) > fcdhid/hidapi.h seems to be ancient version [1.1] of today's hidapi [1.2], > which has own hidapi-devel package ready on Fedora. Either it should declare > bundled(hidapi), better it should be modified to work and link with hidapi > package if possible. If not possible, it should describe briefly reason for > it in spec. Ideally provides should also report bundled version, if upstream > is able to provide it. > Actually it's bundling qthid which is bundling hidapi :) It seems it cannot be built with the upstream qthid, thus adding bundled(qthid) and I am trying to unbundle the hidapi. > I think qrtplib subdirectory contains JRTPLIB, which should be declared by > Provides: bundled(JRTPLIB) [2]. > Added. > httpserver contains part of QtWebApp, should Provides: bundled(QtWebApp) as > well [3]. > Added. > Sources provide also rescuesdriq tool written in Go language. Might be built > as well, but I admit I lack knowledge to build go project in proper way. > That is purely optional. > It's helper tool for repairing broken IQ files. It is not covered by the project CMake thus I think upstream doesn't want it to be installed by default, thus I will not package it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2045924 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
