https://bugzilla.redhat.com/show_bug.cgi?id=2053963 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |mikel@xxxxxxxxxxxxxxx CC| |mikel@xxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- > %global common_description %{expand: > Xkcd style password generator library and cli tool.} > (...) > Summary: Xkcd style password generator library and cli tool Should be `xkcd` instead of `Xkcd` as described in https://xkcd.com/about/ > %global godocs README.md wordlists/eff_short_wordlist_2_0.txt\\\ > wordlists/eff_large_wordlist.txt\\\ > wordlists/de_wordlist.txt > %doc README.md wordlists/eff_short_wordlist_2_0.txt > %doc wordlists/eff_large_wordlist.txt wordlists/de_wordlist.txt The wordlist are included in the code, I don't think they should go as doc. > for cmd in _generator; do > %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd > done The cmd in _generator is used to generate the generated.go file in xkcdpwgen, I don't think it makes sense to ship it in Fedora > BuildRequires: golang(golang.org/x/tools/imports) > (...) > %generate_buildrequires > %go_generate_buildrequires As the package only depends on golang(golang.org/x/tools/imports) and in golang(github.com/stretchr/testify/assert) for tests, maybe you can just use one method. On top of all that, consider using rpmautospec for easier future maintenance. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2053963 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
