https://bugzilla.redhat.com/show_bug.cgi?id=2040118 --- Comment #12 from Garry T. Williams <gtwilliams@xxxxxxxxx> --- Spec URL: https://raw.githubusercontent.com/gtwilliams/deal/v3.1.11/deal.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/gtwilliams/deal/fedora-35-x86_64/03531399-deal/deal-3.1.11-2.fc35.src.rpm (In reply to Artur Frenszek-Iwicki from comment #10) > From the build log: > > gcc -ansi -Wall -O3 -fPIE -g -I/usr/include/tcl -c -o hand.o hand.c > > gcc -ansi -Wall -O3 -fPIE -g -I/usr/include/tcl -c -o tcl_dds.o tcl_dds.c > > gcc -ansi -Wall -O3 -fPIE -g -I/usr/include/tcl -c -o dealtypes.o dealtypes.c > > ... > Fedora's CFLAGS are not applied here. Looking at the Makefile, it overwrites > CFLAGS in line 39. > CPPFLAGS are also overwritten in Make.fedora on line 5. Fixed. > > cp -a docs/html %{build_docs}/ > > ... > > %files > > %doc %{_docdir}/%{name}/ > You don't need to copy the files manually. If you use a relative path with > %doc, > the build process will take the file from the build directory and copy it > to the buildroot for you. > > > cp -a GPL %{build_docs} > > ... > > %files > > %license %{_docdir}/%{name}/GPL > The same for %license. I cannot get the build to copy the files here. I removed the cp commands and the result is no files in /usr/share/doc/deal. > > %build > > %set_build_flags > I know it was me who suggested this a month ago, but - setting the build > flags manually > is no longer needed. Starting with Fedora 36, this will be done > automatically. > https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck OK, but this still is required for now. I can remove the %set_build_flags when I later build for F36. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2040118 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
