https://bugzilla.redhat.com/show_bug.cgi?id=2040728 --- Comment #13 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- Hello, Phil. Sorry for making you wait so long. So, first of all, there are a couple of bundled libraries in the upstream source. You adjust the License field to encompass these libraries as well. 1. cJSON: MIT license - app/bin/cJSON.h - app/bin/cJSON.c This is packaged for Fedora under the name "cjson". You should either: a) BuildRequire cjson-devel and swap the bundled version for the distro version. b) Add "Provides: bundled(cjson) = 1.7.8" to the spec. 2. dirent: MIT license - app/bin/include/dirent.h This file seems to be a compatibility header for MS Windows, and likely can be safely patched out from the Linux package. 3. xdg-open: MIT license - app/lib/xdg-open Can likely be replaced with a symlink to /usr/bin/xdg-open, as provided by the "xdg-utils" package. There is also a bundled copy of halibut, the text formatting system. (Also MIT-licensed, found in app/tools/halibut.) It is not installed as part of the final package, but it is compiled during the build process and used to process some files. Since halibut is packaged in Fedora ("halibut" package), it would be useful to look into the possibility of using the distro-provided program, instead of having xtrkcad build its own bundled copy. Next thing, the package provides a MIME info file under /usr/share/xtrkcad/applications/xtrkcad.xml. This should be moved to /usr/share/mime/packages/. The package also installs a "xtrkcad-setup" file in /usr/share/xtrkcad; looking at the script, it seems to be an installer for a local user. This can be removed. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2040728 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
