https://bugzilla.redhat.com/show_bug.cgi?id=2053935 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED CC| |mikel@xxxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |mikel@xxxxxxxxxxxxxxx --- Comment #1 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- - No need of %build section - No need of debug_package part About file ownership, package should own also %{_includedir}/google: - Add "%dir %{_includedir}/google" - Change to %{_includedir}/google/* This causes the following warning with fedora-review, other packages also own %{_includedir}/google: [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/google(gperftools-devel, sparsehash-devel, protobuf-c- devel, protobuf-devel) - Package should have a -devel subpackage for proto files like `protobuf` or `protobuf-c` do. - You may want to switch to rpmautospec, https://docs.pagure.org/Fedora-Infra.rpmautospec/index.html For the `Release` tag you check https://mikel.olasagasti.info/tmp/fedora/shdoc.spec on how you can use it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2053935 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
