[Bug 2053682] Review Request: stellarsolver - The Cross Platform Sextractor and Internal Astrometric Solver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2053682



--- Comment #2 from Mattia Verga <mattia.verga@xxxxxxxxxxxxxx> ---
(In reply to Sandro Mani from comment #1)
> - I guess MIT should also appear in License:
> 
> ./stellarsolver/sep/MIT_LICENSE.txt: MIT License
> ./stellarsolver/astrometry/blind/windirent.h: MIT License
> 

Fixed.

> - rpmlint complians:
> 
> stellarsolver.x86_64: W: binary-or-shlib-calls-gethostbyname
> /usr/bin/StellarSolverTester
> stellarsolver-libs.x86_64: W: binary-or-shlib-calls-gethostbyname
> /usr/lib64/libstellarsolver.so.1.9
> 
> Upstream could be asked to port to getaddrinfo
> 

The affected code (/stellarsolver/astrometry/blind/solvedclient.c) has already
been removed in the master branch.

> - Nitpick:
> 
> find %{buildroot} -name '*.la' -exec rm -f {} ';'
> 
> is usually only needed to autotools, doesn't look necessary here.

Fixed.

Spec URL: https://mattia.fedorapeople.org/stellarsolver/stellarsolver.spec
SRPM URL:
https://mattia.fedorapeople.org/stellarsolver/stellarsolver-1.9-2.20220211git832bc60.fc37.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2053682
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux