https://bugzilla.redhat.com/show_bug.cgi?id=2050889 --- Comment #7 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review! (In reply to Lumír Balhar from comment #6) > Notes from me: > - Could you please add a command you used to generate the manpage to the > comment in the specfile? Or, might this be automated during the build so > it's not an extra manual step during updates? It’s *hand*-written based on package metadata and --help output. I don’t expect it to need to change too often, and it’s hard to get nice output with tools like help2man. Maybe I can make that more clear in the comment above Source1. > - You don't need to "cp -p '%{SOURCE1}' .", you can just use %{SOURCE1} in > %install: > install -t '%{buildroot}/%{_mandir}/man1' -D -p -m 0644 %{SOURCE1} True. I’ll simplify it as you have suggested. > - Version 0.14.0 is available upstream That was fast! I’ll review the source diff and update it promptly. Upstream release monitoring will keep me in the loop once I’ve imported the package. > - You don't need this line: > %dir %{python3_sitelib}/hatchling-%{version}.dist-info/license_files > the license file stays in the directory and the whole dist-info belongs to > the package. I’m not sure this is true. If I remove the line, I get: $ rpm -q --filesbypkg -p /var/lib/mock/fedora-36-x86_64/result/python3-hatchling-0.11.3-1.fc36.noarch.rpm python3-hatchling /usr/bin/hatchling python3-hatchling /usr/lib/python3.10/site-packages/hatchling python3-hatchling /usr/lib/python3.10/site-packages/hatchling-0.11.3.dist-info python3-hatchling /usr/lib/python3.10/site-packages/hatchling-0.11.3.dist-info/INSTALLER python3-hatchling /usr/lib/python3.10/site-packages/hatchling-0.11.3.dist-info/METADATA python3-hatchling /usr/lib/python3.10/site-packages/hatchling-0.11.3.dist-info/WHEEL python3-hatchling /usr/lib/python3.10/site-packages/hatchling-0.11.3.dist-info/entry_points.txt python3-hatchling /usr/lib/python3.10/site-packages/hatchling-0.11.3.dist-info/license_files/LICENSE.txt python3-hatchling /usr/lib/python3.10/site-packages/hatchling/__about__.py […] without the license_files subdirectory listed anywhere. If I check the contents of the pyproject-files file, I see: %dir /usr/lib/python3.10/site-packages/hatchling %dir /usr/lib/python3.10/site-packages/hatchling-0.11.3.dist-info %dir /usr/lib/python3.10/site-packages/hatchling/__pycache__ […] %dir /usr/lib/python3.10/site-packages/hatchling/version/source/plugin/__pycache__ /usr/lib/python3.10/site-packages/hatchling-0.11.3.dist-info/INSTALLER /usr/lib/python3.10/site-packages/hatchling-0.11.3.dist-info/METADATA /usr/lib/python3.10/site-packages/hatchling-0.11.3.dist-info/WHEEL /usr/lib/python3.10/site-packages/hatchling-0.11.3.dist-info/entry_points.txt /usr/lib/python3.10/site-packages/hatchling/__about__.py […] which indicates pyproject-rpm-macros is listing directories and files explicitly, not listing the .dist-info directory recursively as one would typically do in a hand-written %files list. Furthermore, if I remove the explicit “%license […]/license_files/LICENSE.txt”, I get: Installed (but unpackaged) file(s) found: /usr/lib/python3.10/site-packages/hatchling-0.11.3.dist-info/license_files/LICENSE.txt which shows the file isn’t packaged automatically, either. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2050889 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
