https://bugzilla.redhat.com/show_bug.cgi?id=2055602 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Thank you for the package! Overall, it looks good, but I think a couple of things should be fixed. > * Tue Feb 15 2022 glaringgibbon <glaringgibbon@xxxxxxxxx> - 3.0.4-1 I am not sure if it is an enforced policy or not but it is common to put a full name into the changelog entries. See the guidelines for an example https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs > Version: 3.0.4 > Source0: https://github.com/pablopunk/%{name}/archive/refs/heads/master.zip You are packaging 3.0.4 version, which is what I would expect but the problem is that you are using different a source tarball. If you look at https://github.com/pablopunk/colortest/commits/master you can see that since the actual 3.0.4 version, multiple commits (9 if I count correctly) have happened. Also, packaging sources from the `master` branch is problematic in another way - each time we would rebuild the package, the sources tarball could be different (if the author pushed some changes in the meantime). You actually want to download the Source0 like this %{URL}/archive/%{version}/%{name}-%{version}.tar.gz See https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags I understand why you needed to package `master` instead of the actual version, which is the added LICENSE file. You will probably have to ask upstream to release 3.0.5 version. A few really nitpicky notes - There are two blank lines between sections but between %files and %changelog, there is just one. Also between the email in the changelog and the dash, there is a double space. Otherwise, I tried the package and it works, so cheers! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2055602 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
