https://bugzilla.redhat.com/show_bug.cgi?id=2055323 --- Comment #2 from Sergio Lopez <slopezpa@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #1) > Two quick notes from Rust packaging POV: > > 1. The package and crate does not contain license files. > You should poke upstream project to include them in published crates. > Until that is resolved, you will probably need to include the two license > files as additional SOURCEs and add them manually. That's the result of this crate being in a shared repository. I'll let upstream know. I think fixing it should be as simple as adding some "license_file" entries in this crate's Cargo.toml. I've added the files as addition SOURCEs, pointing to URLs where the license files reside in the shared repository. > 2. %cargo_test "--features" test-utils > > This looks weird, not sure if that even works as expected. > The %cargo_test macro even has an "-f" flag for this exact use case: > > %cargo_test -f test-utils It works, but I agree it's weird. I've fixed it too. https://download.copr.fedorainfracloud.org/results/slp/rust-virtio-queue/fedora-36-x86_64/03517131-rust-virtio-queue/rust-virtio-queue.spec https://download.copr.fedorainfracloud.org/results/slp/rust-virtio-queue/fedora-36-x86_64/03517131-rust-virtio-queue/rust-virtio-queue-0.1.0-1.fc36.src.rpm Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2055323 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
