Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: rdesktop https://bugzilla.redhat.com/show_bug.cgi?id=226358 tyler.l.owen@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From tyler.l.owen@xxxxxxxxx 2007-12-03 22:32 EST ------- ------------------------------------------- Summary: ------------------------------------------- * rpmlint not silent * License needs updating to new format * Source0 does not contain full URL * Desktop file not installed correctly ------------------------------------------- Details: ------------------------------------------- OK - Mock : Built on Koji dist-f8 & dist-f9 OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. FIX - License field in spec matches FIX - License in new format OK - License matches Fedora packaging policy licenses allowed OK - License file is included in package OK - Spec in American English OK - Spec is legible. FIX - Sources SHOULD match upstream md5sum: 433546f60fc0f201e99307ba188369ed rdesktop-1.5.0.tar.gz * Source tag missing full path to source. Should be: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz OK - Package has correct buildroot. OK - BuildRequires are not redundant. OK - %build and %install stages are correct and work. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories that other packages own. OK - Changelog section is correct. OK - Should function as described. OK - Should package latest version ------------------------------------------- Rpmlint output: ------------------------------------------- FIX - SRPM rdesktop.src: W: invalid-license GPL FIX - RPM rdesktop.i386: W: file-not-utf8 /usr/share/doc/rdesktop-1.5.0/licensing.txt rdesktop.i386: W: file-not-utf8 /usr/share/doc/rdesktop-1.5.0/AUTHORS rdesktop.i386: W: invalid-license GPL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review