https://bugzilla.redhat.com/show_bug.cgi?id=2030595 --- Comment #11 from xiangquan.liu@xxxxxxxxx --- Hi Paolo, My comments are as below. * the static binary-only libraries in external/ should be removed from the sources tarball and should not be used during the build process. [Xiangquan] 1. Binutils Toolset can be removed since it is not needed for fedora36. For the prebuilt opt libs, only IPP is a must for the default build. Reasons we use the prebuilt IPP instead of building from OpenSource: a. IPP build has some tool dependency and tool version requirement. Not all the OSes we supported meet this requirement. We don’t want to bring the dependency to SGX build. b. It takes long time to build the IPP from source code. * OpenSSL should be built from source, and the OpenSSL sources should be passed through the "hobble-openssl" script from the Fedora OpenSSL package. The script removes certain patented algorithms from the tarball. [Xiangquan] Not quite clear about this issue. Could you please provide more information? Thanks! * No network access should be done during the build (see for example external/sgxssl/prepare_sgxssl.sh); all sources should be included in the tarball. [Xiangquan] Please don't care about this script which won't be called in this build process. All source codes are included in the tarball. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2030595 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
