https://bugzilla.redhat.com/show_bug.cgi?id=2034758 --- Comment #20 from Dave Dykstra <dwd@xxxxxxxxxxxxxxxxx> --- Thanks for the review, Maxwell. I have made an updated version: Spec URL: https://github.com/DrDaveD/apptainer/releases/download/v1.0.0-rc.2-3/apptainer.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3275/82863275/apptainer-1.0.0~rc.2-3.fc37.src.rpm Koji build https://koji.fedoraproject.org/koji/taskinfo?taskID=82863274 The standard %prep macros weren't being used because of historical reasons which are no longer applicable, so that's a very good improvement. I'm not happy about having to remove SUSE macros because that means I can't directly use the upstream package's own .spec file. I think that's a bad rule, but I took it out anyway. I didn't want to remove the if-ed out code referencing %SOURCE because it might be needed someday if golang again lags behind a needed version. I don't think there's a rule against it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2034758 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
