[Bug 2041073] Review Request: libnvme - Linux-native nvme device management library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2041073



--- Comment #12 from Tomáš Bžatek <tbzatek@xxxxxxxxxx> ---
(In reply to Neal Gompa from comment #10)
> > URL:     https://github.com/linux-nvme/libnvme
> > Source0: https://github.com/linux-nvme/libnvme/archive/v%{version_no_tilde}/%{name}-%{version_no_tilde}.tar.gz
> 
> You can simplify Source0 to this:
> 
> Source0:
> %{url}/archive/v%{version_no_tilde}/%{name}-%{version_no_tilde}.tar.gz

Changed.

> > %{_libdir}/libnvme.so.*
> 
> This glob is too greedy, you need to track the soversion in here.

Fixed, included full version. It's not that much work when rebasing to a
newever release.


Updated build:
https://copr.fedorainfracloud.org/coprs/g/storage/udisks-daily/build/3503845/
Spec:
https://download.copr.fedorainfracloud.org/results/@storage/udisks-daily/fedora-36-x86_64/03503845-libnvme/libnvme.spec
SRPM:
https://download.copr.fedorainfracloud.org/results/@storage/udisks-daily/fedora-36-x86_64/03503845-libnvme/libnvme-1.0~rc3-1.fc36.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2041073
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux