https://bugzilla.redhat.com/show_bug.cgi?id=2045955 --- Comment #17 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> --- (In reply to Felix Schwarz from comment #16) > Thank you for filing patches upstream and great that you were able to break > the cyclic dependency. > > Short version: package approved Thanks! :) > > Two things I'd like to see fixed/changed. > > - "0002-Update-NOTICES.txt.patch": The patch seems obviously correct (no > "yaml-cpp" directory present anymore) but (imho) we should not tweak > licensing documents downstream. Would you mind dropping that patch before > the initial import? (I think we don't have to do anything else like changing > the license tag, just ship the NOTICES.txt unmodified.) That's fine, it'll be merged upstream soon anyway. > - Upstream also has a test suite. Can we run these in %check? (If this is > too hard or not possible due to missing dependencies, we can ignore the test > suite of course.) Yeah I'm going to look into this. If I can enable it easily, I will. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2045955 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
