https://bugzilla.redhat.com/show_bug.cgi?id=2053822 --- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- "Free and open-source" applies to all packages in Fedora. So that part of the Summary is not useful. And it you don't know what "monero" is, and I don't, the rest won't tell you much either… Please try to write the Summary+description so that it is meaningful to someone who is completely new to the subject. Also "written in C++ with the Qt framework" is not terribly interesting to users. You can mention Qt, but other details of implementation are unimportant. > sed -i 's/^\(Icon\|Exec\)=feather$/&wallet/' %{buildroot}%{_datadir}/applications/featherwallet.desktop > sed -i 's/^Name=Feather$/& Wallet/' %{buildroot}%{_datadir}/applications/featherwallet.desktop Those commands should be in %prep. This is where we apply patches and do other modifications to sources. > mkdir -p %{buildroot}%{_bindir} %{buildroot}%{_datadir}/applications %{buildroot}%{_datadir}/pixmaps > cp %{_vpath_builddir}/bin/feather %{buildroot}%{_bindir}/featherwallet > cp src/assets/feather.desktop %{buildroot}%{_datadir}/applications/featherwallet.desktop It's a bit nicer to say: install -D %{buildroot}%{_bindir}/featherwallet %{_vpath_builddir}/bin/feather install -m0644 -D %{buildroot}%{_datadir}/applications/featherwallet.desktop src/assets/feather.desktop etc. I'd recommend dropping the manual Release and %changelog handling. See https://docs.pagure.org/fedora-infra.rpmautospec/index.html. > %global debug_package %{nil} Why? This is usually a sign of other problem with the build systems, usually missing flags. Please drop this and instead figure out what is needed to for the -debuginfo package to generate properly. Since this is a graphical application, it should have an appdata file: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ (with a pretty screenshot ;)) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2053822 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
