[Bug 2045955] Review Request: rocm-compilersupport - Various AMD ROCm LLVM related services

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2045955



--- Comment #13 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> ---
(In reply to Felix Schwarz from comment #12) 
> Fair enough. I'd prefer not to use company names for package names if not
> really necessary (abundance of caution, trademarks and all of that). While
> Debian has a lot of 'lib*' packages we also have some of these in Fedora as
> well though Fedora also uses '*-libs' for fine-grained dependencies. Anyway
> - no strong feelings on my side and in the end even Debian calls the package
> "rocm-comgr" if I understood Debian's git repo correctly.

I just checked and you're indeed correct. Not sure why. Colour me surprised :)
Regardless, since the source package is different, it gives flexibility to
change it later.

> Feel free to submit the tweaked spec ("rocm-compilersupport-devel") and I'll
> do a review to move this forward.

Done, see update below

> Just fyi: I recompiled the OpenCL package for F35 but was unable to get
> "clinfo" to recognize my gfx card. However this is a RX570/gfx803 and the
> card is not officially supported so it might be also due to unsupported
> hardware.

Yes, I think to enable the pre-vega experimental support, you need to export
ROC_ENABLE_PRE_VEGA=true or something like that.
I don't see it documented anywhere, but I noticed it in when I was trying to
debug the aarch64 build. As well, I'm told it's really buggy, so be warned :)
I should have a vega, so I can test it later.

I also reviewed the licensing and noticed some issues, so I ended up making a
pull request anyway.

Spec URL: https://mystro256.fedorapeople.org/rocm-compilersupport.spec
SRPM URL:
https://mystro256.fedorapeople.org/rocm-compilersupport-5.0.0-1.fc37.src.rpm
COPR:
https://copr.fedorainfracloud.org/coprs/mystro256/rocm-opencl/build/3487501/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2045955
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux