https://bugzilla.redhat.com/show_bug.cgi?id=2045955 --- Comment #12 from Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> --- > "libcomgr" is a very Debian style of naming packages. I prefer rocm-comgr because it's more descriptive to users, which seems like the more fedora thing to do :) > > Although with that said, the library is actually called libamd_comgr, so alternatively we can match the cmake file name and call the package "amd-comgr". Fair enough. I'd prefer not to use company names for package names if not really necessary (abundance of caution, trademarks and all of that). While Debian has a lot of 'lib*' packages we also have some of these in Fedora as well though Fedora also uses '*-libs' for fine-grained dependencies. Anyway - no strong feelings on my side and in the end even Debian calls the package "rocm-comgr" if I understood Debian's git repo correctly. Feel free to submit the tweaked spec ("rocm-compilersupport-devel") and I'll do a review to move this forward. > While I haven't specifically tested 5.0.0 on real HW, I don't expect functional issues. Just fyi: I recompiled the OpenCL package for F35 but was unable to get "clinfo" to recognize my gfx card. However this is a RX570/gfx803 and the card is not officially supported so it might be also due to unsupported hardware. $ rocm-clinfo Number of platforms: 1 Platform Profile: FULL_PROFILE Platform Version: OpenCL 2.2 AMD-APP (3406.0) Platform Name: AMD Accelerated Parallel Processing Platform Vendor: Advanced Micro Devices, Inc. Platform Extensions: cl_khr_icd cl_amd_event_callback Platform Name: AMD Accelerated Parallel Processing Number of devices: 0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2045955 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
