https://bugzilla.redhat.com/show_bug.cgi?id=2045955 --- Comment #9 from Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> --- > Sure, I realize my comment was very confusing, see updated. The issue is that upstream still wants to compile statically, but my patch forces dynamic linking. I need to figure out how to fix my patch to autodetect before submitting upstream. Makes sense, thank you for the explanation. > I emailed the patch directly to the developers, not a public mailing list. Alternatively, I can make a pull request on github if desired. As far a I know, github is just a mirror of an internal repo they have, so I thought it would be easier for them to apply the patch if I email the developers directly. Well, that's fine by me if it helps getting the patch applied. In general it would be nice if ROCm development would happen more in the open. As a Fedora packager please be aware of your special position as an AMD employee. I know it's very tempting to use "private" (and more efficient) communication but it excludes other (also potential) Fedora packagers. So in general it would be nice if the public git repos would put everyone on the same footing (I think also AMD would benefit from that eventually). > %{_libdir}/libamd_comgr.so.* Please list a more specific so name: The idea is that the packager should be aware of soname changes and this is more likely if (s)he needs to adapt the file name in the .spec explicitely. See also: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files Other than that I think the package looks good, will try a review soon. > Here's the rocm-opencl build if you're interested: > https://copr.fedorainfracloud.org/coprs/mystro256/rocm-opencl/builds/ Great, thank you! > The rocm-opencl package is full of problems, but it might help if you want to test something. packaging problems or should I also expect functional problems? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2045955 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
