https://bugzilla.redhat.com/show_bug.cgi?id=2045955 --- Comment #6 from Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> --- SRPM URL: https://mystro256.fedorapeople.org/rocm-compilersupport-5.0.0-1.fc36.src.rpm rocm-comgr contains LICENSE.txt, NOTICES.txt, and README.md in /usr/share/amd_comgr (duplicated, should be removed) Some patches could use a link or an explanation: - "Upstream is ok with the patch, but my patch isn't currently upstreamable": why is the patch ok for Fedora but not for upstream? - "Fix location of cmake file, I've already emailed upstream a patch" - link? One surprising thing was the number of required compilers: BuildRequires: gcc BuildRequires: gcc-c++ BuildRequires: clang-devel the package needs gcc AND clang? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2045955 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
