Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: objectweb-asm - Version 3.0 of the ObjectWeb ASM https://bugzilla.redhat.com/show_bug.cgi?id=254008 loganjerry@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |loganjerry@xxxxxxxxx Flag| |fedora-review? ------- Additional Comments From loganjerry@xxxxxxxxx 2007-12-03 17:28 EST ------- Looks great. I'll just note that the BuildRequires on dos2unix isn't necessary. You could do this: sed -i 's/\r//' README.txt LICENSE.txt since sed is in the default build root, but that's a minor point. I'll mark this as passing review (in 2 steps, since I didn't remember to mark this as under review, yikes!). Thanks for all your work! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review