[Bug 2051874] Review Request: rust-ifcfg-devname - Udev helper utility that provides network interface naming

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2051874

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yuwatana@xxxxxxxxxx,
                   |                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
             Status|NEW                         |ASSIGNED



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
rpmlint:
ifcfg-devname.x86_64: W: spelling-error Summary(en_US) Udev -> Dude
ifcfg-devname.x86_64: W: spelling-error Summary(en_US) cmdline -> decline
ifcfg-devname.x86_64: E: summary-too-long C Udev helper utility that provides
network interface naming using kernel cmdline and ifcfg configuration

I think rpmlint is right that Summary is too long. Maybe "Udev helper to name
interfaces in kernel cmdline and ifconfig files"?

Since this is using rust2rpm template, there isn't much to check.
+ package name is OK
+ license is acceptable for Fedora (GPLv3)
+ license is specified correctly
+ latest version
+ R/P/BR look OK
+ fedora-review and rpmlint find no issues, except as noted above

The only question I have is how this relates to systemd-network-generator.
In particular, s-n-g understands ifname=, and it would be awkward if both
utilities tried to
handle it.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2051874
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux