[Bug 2050552] Review Request: python-elasticsearch7 - Client for Elasticsearch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2050552

Steve Traylen <steve.traylen@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value



--- Comment #2 from Steve Traylen <steve.traylen@xxxxxxx> ---
Thankyou for the review.

Updated packages:

Spec URL:
https://cern.ch/straylen/rpms/python-elasticsearch7/python-elasticsearch7.spec
SRPM URL:
https://cern.ch/straylen/rpms/python-elasticsearch7/python-elasticsearch7-7.17.0-2.el9.src.rpm


Comments:

>suggest replacing the following int the specfile:
>    - %{python3_sitelib}/%{pypi_name}-%{version}-py3.?.egg-info
>  with:
>    + %{python3_sitelib}/%{pypi_name}-%{version}-py%{python_version}.egg-info

Absolutely , got lucky on EPEL8.


> license.cpython-36.opt-1.pyc is not marked as %license
It's just a library file that happens to be called license. It reads the
elasticsearch license of the server you are talking to.

> The %checks

All the upstream tests require that you have a running elasticsearch server.
I've added to a comment to that effect and
also added a simple module import of elasticsearch7 which I should have done in
the first place.

I believe that addresses everything.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2050552
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux