[Bug 2051008] Review Request: ffmpeg - A complete solution to record, convert and stream audio and video

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2051008



--- Comment #42 from Neal Gompa <ngompa13@xxxxxxxxx> ---
(In reply to Fabio Valentini from comment #41)
> Huh, some of those rpmlint warnings sound useful ...
> 
> > ffmpeg-free-libs.x86_64: W: crypto-policy-non-compliance-gnutls-1 /usr/lib64/libavformat.so.59.16.100 gnutls_priority_set_direct
> 
> Is this expected?
> 

It's an old policy from attempts to unify crypto libraries. We never completed
it and I believe those checks were removed in rpmlint 2.x.

> > ffmpeg.src: W: strange-permission ffmpeg_clean_sources.sh 755
> 
> Does it maybe expect 775 instead? Or does it complain about it being an
> executable?
> 

This is some rpmlint-1.x goofiness. It should be 755, and that's what Git will
store it as.

> > ffmpeg.src:351: E: use-of-RPM_SOURCE_DIR
> 
> I guess you could copy those files into the local build directory first.
> Would be "cleaner".
> 
> > ffmpeg.src:474: W: macro-in-%changelog %prep
> 
> That unescaped "%prep" needs to be removed from the changelog, or escaped
> properly.
> 

Hmm, yeah, that's true. I glossed over this one in the sea of the others.

> > ffmpeg.src: W: file-size-mismatch ffmpeg.keyring = 1203, https://ffmpeg.org/ffmpeg-devel.asc#/ffmpeg.keyring = 1709
> 
> What's this about? Why doesn't the keyring file match?
> This is probably also the reason for the MD5sum mismatch error.

Looks like the keyring file got updated.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2051008
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux