https://bugzilla.redhat.com/show_bug.cgi?id=2051008 --- Comment #39 from Neal Gompa <ngompa13@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/ngompa/2051008-ffmpeg/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License, Version 3", "*No copyright* GNU General Public License v2.0 or later", "*No copyright* GNU General Public License", "GNU Lesser General Public License v2.1 or later", "*No copyright* GNU Lesser General Public License v2.1 or later", "MIT License", "BSD (3 clause)", "GNU General Public License v3.0 or later", "*No copyright* [generated file]", "GNU General Public License v2.0 or later", "*No copyright* MIT License", "ISC License", "BSD (3 clause) GNU Lesser General Public License v2.1 or later", "BSD (2 clause)", "MIT License GNU Lesser General Public License v2.1 or later", "BSD (2 clause) GNU Lesser General Public License v2.1 or later", "zlib/libpng license", "Boost Software License 1.0 GNU Lesser General Public License v2.1 or later", "*No copyright* Public domain". 256 files have unknown license. Detailed output of licensecheck in /home/ngompa/2051008-ffmpeg/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Only use %_sourcedir in very specific situations. Note: %_sourcedir/$RPM_SOURCE_DIR is used. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 563200 bytes in 46 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ffmpeg- free , ffmpeg-free-libs , ffmpeg-free-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/ngompa/2051008-ffmpeg/srpm- unpacked/ffmpeg.spec See: (this test has no URL) [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2293760 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: ffmpeg-free-5.0-8.fc36.x86_64.rpm ffmpeg-free-libs-5.0-8.fc36.x86_64.rpm ffmpeg-free-devel-5.0-8.fc36.x86_64.rpm ffmpeg-debuginfo-5.0-8.fc36.x86_64.rpm ffmpeg-debugsource-5.0-8.fc36.x86_64.rpm ffmpeg-5.0-8.fc36.src.rpm ffmpeg-free.x86_64: W: spelling-error %description -l en_US transcode -> trans code, trans-code, transcendent ffmpeg-free.x86_64: W: spelling-error %description -l en_US mux -> mix, mu, mus ffmpeg-free.x86_64: W: spelling-error %description -l en_US demux -> demur ffmpeg-free-libs.x86_64: W: spelling-error %description -l en_US transcode -> trans code, trans-code, transcendent ffmpeg-free-libs.x86_64: W: spelling-error %description -l en_US mux -> mix, mu, mus ffmpeg-free-libs.x86_64: W: spelling-error %description -l en_US demux -> demur ffmpeg-free-libs.x86_64: W: crypto-policy-non-compliance-gnutls-1 /usr/lib64/libavformat.so.59.16.100 gnutls_priority_set_direct ffmpeg-free-devel.x86_64: W: spelling-error %description -l en_US transcode -> trans code, trans-code, transcendent ffmpeg-free-devel.x86_64: W: spelling-error %description -l en_US mux -> mix, mu, mus ffmpeg-free-devel.x86_64: W: spelling-error %description -l en_US demux -> demur ffmpeg.src: W: spelling-error %description -l en_US transcode -> trans code, trans-code, transcendent ffmpeg.src: W: spelling-error %description -l en_US mux -> mix, mu, mus ffmpeg.src: W: spelling-error %description -l en_US demux -> demur ffmpeg.src: W: strange-permission ffmpeg_clean_sources.sh 755 ffmpeg.src:351: E: use-of-RPM_SOURCE_DIR ffmpeg.src:474: W: macro-in-%changelog %prep ffmpeg.src: W: file-size-mismatch ffmpeg.keyring = 1203, https://ffmpeg.org/ffmpeg-devel.asc#/ffmpeg.keyring = 1709 ffmpeg.src: W: invalid-url Source0: ffmpeg-free-5.0.tar.xz 6 packages and 0 specfiles checked; 1 errors, 17 warnings. Rpmlint (debuginfo) ------------------- Checking: ffmpeg-free-libs-debuginfo-5.0-8.fc36.x86_64.rpm ffmpeg-debuginfo-5.0-8.fc36.x86_64.rpm ffmpeg-free-debuginfo-5.0-8.fc36.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://ffmpeg.org/ffmpeg-devel.asc#/ffmpeg.keyring : CHECKSUM(SHA256) this package : fd543a75d3bba61b759ca25b135e6f91b34aa37ae6987316e5c636bf3c78ae8d CHECKSUM(SHA256) upstream package : 397b3becedcd5a98769967ff1ff8501ddc89f8368b8f766e4701377d7dbaabe5 https://ffmpeg.org/releases/ffmpeg-5.0.tar.xz.asc : CHECKSUM(SHA256) this package : 25fc8a9de93e3ff086451bf5780704368675612e39c8209c31802f057281baed CHECKSUM(SHA256) upstream package : 25fc8a9de93e3ff086451bf5780704368675612e39c8209c31802f057281baed diff -r also reports differences Requires -------- ffmpeg-free (rpmlib, GLIBC filtered): ffmpeg-free-libs(x86-64) glibc libSDL2-2.0.so.0()(64bit) libavcodec.so.59.18()(64bit) libavcodec.so.59.18(LIBAVCODEC_59)(64bit) libavdevice.so.59.4()(64bit) libavdevice.so.59.4(LIBAVDEVICE_59)(64bit) libavfilter.so.8.24()(64bit) libavfilter.so.8.24(LIBAVFILTER_8)(64bit) libavformat.so.59.16()(64bit) libavformat.so.59.16(LIBAVFORMAT_59)(64bit) libavutil.so.57.17()(64bit) libavutil.so.57.17(LIBAVUTIL_57)(64bit) libc.so.6()(64bit) libm.so.6()(64bit) libpostproc.so.56.3()(64bit) libpostproc.so.56.3(LIBPOSTPROC_56)(64bit) libswresample.so.4.3()(64bit) libswresample.so.4.3(LIBSWRESAMPLE_4)(64bit) libswscale.so.6.4()(64bit) libswscale.so.6.4(LIBSWSCALE_6)(64bit) rtld(GNU_HASH) ffmpeg-free-libs (rpmlib, GLIBC filtered): glibc libSDL2-2.0.so.0()(64bit) libSvtAv1Enc.so.0()(64bit) libX11.so.6()(64bit) libaom.so.3()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libass.so.9()(64bit) libavcodec.so.59.18()(64bit) libavcodec.so.59.18(LIBAVCODEC_59)(64bit) libavfilter.so.8.24()(64bit) libavfilter.so.8.24(LIBAVFILTER_8)(64bit) libavformat.so.59.16()(64bit) libavformat.so.59.16(LIBAVFORMAT_59)(64bit) libavutil.so.57.17()(64bit) libavutil.so.57.17(LIBAVUTIL_57)(64bit) libbluray.so.2()(64bit) libbs2b.so.0()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libcdio_cdda.so.2()(64bit) libcdio_cdda.so.2(CDIO_CDDA_2)(64bit) libcdio_paranoia.so.2()(64bit) libcdio_paranoia.so.2(CDIO_PARANOIA_2)(64bit) libdav1d.so.5()(64bit) libdc1394.so.25()(64bit) libdrm.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libfribidi.so.0()(64bit) libgnutls.so.30()(64bit) libgnutls.so.30(GNUTLS_3_4)(64bit) libgsm.so.1()(64bit) libjack.so.0()(64bit) liblzma.so.5()(64bit) liblzma.so.5(XZ_5.0)(64bit) libm.so.6()(64bit) libmp3lame.so.0()(64bit) libmysofa.so.1()(64bit) libopenjp2.so.7()(64bit) libopenmpt.so.0()(64bit) libopus.so.0()(64bit) libpostproc.so.56.3()(64bit) libpostproc.so.56.3(LIBPOSTPROC_56)(64bit) libpulse.so.0()(64bit) libpulse.so.0(PULSE_0)(64bit) librav1e.so.0()(64bit) librubberband.so.2()(64bit) libsmbclient.so.0()(64bit) libsmbclient.so.0(SMBCLIENT_0.1.0)(64bit) libsoxr.so.0()(64bit) libspeex.so.1()(64bit) libsrt.so.1.4()(64bit) libssh.so.4()(64bit) libssh.so.4(LIBSSH_4_5_0)(64bit) libswresample.so.4.3()(64bit) libswresample.so.4.3(LIBSWRESAMPLE_4)(64bit) libswscale.so.6.4()(64bit) libswscale.so.6.4(LIBSWSCALE_6)(64bit) libtheoradec.so.1()(64bit) libtheoradec.so.1(libtheoradec_1.0)(64bit) libtheoraenc.so.1()(64bit) libtheoraenc.so.1(libtheoraenc_1.0)(64bit) libtwolame.so.0()(64bit) libv4l2.so.0()(64bit) libva-drm.so.2()(64bit) libva-x11.so.2()(64bit) libva.so.2()(64bit) libva.so.2(VA_API_0.33.0)(64bit) libvdpau.so.1()(64bit) libvidstab.so.1.2()(64bit) libvmaf.so.1()(64bit) libvorbis.so.0()(64bit) libvorbisenc.so.2()(64bit) libvpx.so.7()(64bit) libwebp.so.7()(64bit) libwebpmux.so.3()(64bit) libxcb-shape.so.0()(64bit) libxcb-shm.so.0()(64bit) libxcb-xfixes.so.0()(64bit) libxcb.so.1()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.2)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.7.3)(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) libz.so.1(ZLIB_1.2.0.2)(64bit) libzimg.so.2()(64bit) rtld(GNU_HASH) ffmpeg-free-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config ffmpeg-free-libs(x86-64) libavcodec.so.59.18()(64bit) libavdevice.so.59.4()(64bit) libavfilter.so.8.24()(64bit) libavformat.so.59.16()(64bit) libavutil.so.57.17()(64bit) libpostproc.so.56.3()(64bit) libswresample.so.4.3()(64bit) libswscale.so.6.4()(64bit) pkgconfig pkgconfig(libavcodec) pkgconfig(libavfilter) pkgconfig(libavformat) pkgconfig(libavutil) pkgconfig(libpostproc) pkgconfig(libswresample) pkgconfig(libswscale) ffmpeg-debuginfo (rpmlib, GLIBC filtered): ffmpeg-debugsource (rpmlib, GLIBC filtered): Provides -------- ffmpeg-free: ffmpeg-free ffmpeg-free(x86-64) ffmpeg-free-libs: ffmpeg-free-libs ffmpeg-free-libs(x86-64) libavcodec.so.59.18()(64bit) libavcodec.so.59.18(LIBAVCODEC_59)(64bit) libavdevice.so.59.4()(64bit) libavdevice.so.59.4(LIBAVDEVICE_59)(64bit) libavfilter.so.8.24()(64bit) libavfilter.so.8.24(LIBAVFILTER_8)(64bit) libavformat.so.59.16()(64bit) libavformat.so.59.16(LIBAVFORMAT_59)(64bit) libavutil.so.57.17()(64bit) libavutil.so.57.17(LIBAVUTIL_57)(64bit) libpostproc.so.56.3()(64bit) libpostproc.so.56.3(LIBPOSTPROC_56)(64bit) libswresample.so.4.3()(64bit) libswresample.so.4.3(LIBSWRESAMPLE_4)(64bit) libswscale.so.6.4()(64bit) libswscale.so.6.4(LIBSWSCALE_6)(64bit) ffmpeg-free-devel: ffmpeg-free-devel ffmpeg-free-devel(x86-64) pkgconfig(libavcodec) pkgconfig(libavdevice) pkgconfig(libavfilter) pkgconfig(libavformat) pkgconfig(libavutil) pkgconfig(libpostproc) pkgconfig(libswresample) pkgconfig(libswscale) ffmpeg-debuginfo: ffmpeg-debuginfo ffmpeg-debuginfo(x86-64) ffmpeg-debugsource: ffmpeg-debugsource ffmpeg-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2051008 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: PHP, R, SugarActivity, Java, fonts, Ocaml, Python, Perl, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2051008 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
