[Bug 2030595] Review Request: sgx-aesm-service - SGX Architectural Enclave Service Manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2030595



--- Comment #8 from Jun.Miao <jun.miao@xxxxxxxxx> ---
About spec:
(In reply to Cestmir Kalina from comment #5)
> Source package includes the text of the license(s) in its own file not
> included in %license.

%license  License.txt

> rpmlint: 2.2.0 checks: 32, packages: 1
> sgx-aesm-service.spec: E: superfluous-%clean-section
> sgx-aesm-service.spec:37: W: mixed-use-of-spaces-and-tabs (spaces: line 8,tab: line 37)

37  ExclusiveArch:  x86_64(two spaces replace the tap)
362 %clean       delete this line                                               
363 make clean   delete this line  


About upstream srpm:
I find even workaround the "error: type ‘struct _thread_data_t’ violates the
C++ One Definition Rule [-Werror=odr]"
There are still many other C++ build error:

    inlined from ‘bool Json::OurReader::readValue()’ at
/home/jmiao/rpmbuild/BUILD/sgx-aesm-service-2.15.100.0/external/CppMicroServices/third_party/jsoncpp.cpp:1228:31:
/usr/include/c++/12/bits/move.h:205:7: error: ‘v.Json::Value::value_’ may be
used uninitialized [-Werror=maybe-uninitialized]
  205 |       __a = _GLIBCXX_MOVE(__b);
      |       ^~~
    inlined from ‘bool Json::OurReader::readValue()’ at
/home/jmiao/rpmbuild/BUILD/sgx-aesm-service-2.15.100.0/external/CppMicroServices/third_party/jsoncpp.cpp:1257:33:
/usr/include/c++/12/bits/move.h:205:7: error: ‘v.Json::Value::value_’ may be
used uninitialized [-Werror=maybe-uninitialized]
  205 |       __a = _GLIBCXX_MOVE(__b);
      |       ^~~
home/jmiao/rpmbuild/BUILD/sgx-aesm-service-2.15.100.0/external/CppMicroServices/build/include/cppmicroservices/GlobalConfig.h:144:26: 
           error: ‘template<class _Arg, class _Result> struct
std::unary_function’ is deprecated [-Werror=deprecated-declarations]
  144 | struct hash<type> : std::unary_function<type, std::size_t> { \
      |                          ^~~~~~~~~~~~~~


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2030595
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux