[Bug 2052402] Review Request: rust-greetd_ipc - Implementation of the greetd IPC protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2052402

Neal Gompa <ngompa13@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |ngompa13@xxxxxxxxx
              Flags|                            |fedora-review+
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |ngompa13@xxxxxxxxx



--- Comment #1 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

Additional note: %autorelease isn't terribly effective if you're putting
version-release in manual changelog entries. You probably want to rework your
changelog entry to not include the release value (since that would be dynamic)
or just switch to %autochangelog. The %autorelease goop at the top of the spec
should be dropped on import too.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2052402
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux