[Bug 2050434] Review Request: python-accept-types - Determine the best content to send in an HTTP response

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2050434

Roman Inflianskas <rominf@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(rominf@xxxxxxxx)  |needinfo?(paul.wouters@aive
                   |                            |n.io)



--- Comment #2 from Roman Inflianskas <rominf@xxxxxxxx> ---
Fixes required:

1. License is MIT, not BSD!

2. First line of the description is corrupted. Missing dot between "request"
and "accept-types"?

3.
https://download.nohats.ca/python-accept-types/python-accept-types-0.4.1-2.fc35.src.rpm
— 404.


Suggestions:

1. Use macro for description:

```
%global _description %{expand:
...}

%description %_description

...

%description -n python3-... %_description
```

2. Reword summary:

"Determine the best content to send in an HTTP response"

"best" is vague, I think there should be something about Accept header.


Questions:

1. Is `BuildRequires:  python3-tox-current-env` necessary? I think it's
installed automatically by `%pyproject_buildrequires -t`


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2050434
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux