https://bugzilla.redhat.com/show_bug.cgi?id=2051008 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(dominik@greysecto | |r.net) | --- Comment #22 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Neal Gompa from comment #17) > Dominik, what would you prefer? > > 1. "ffmpeg" in Fedora and "ffmpeg-freeworld" in RPM Fusion > 2. "ffmpeg-free" in Fedora and "ffmpeg" in RPM Fusion > > There are trade-offs for each choice: > > Option 1 means that packages that explicitly request the ffmpeg package by > name will be able to have their dependencies satisfied by the Fedora one. > This means that there may be some short-term pain by applications that > expect more codecs from our ffmpeg than are available at this time. However, > this will force us to find avenues/mechanisms to dynamically expand codec > availability sooner rather than later. We can only wait for patents to expire, so there's not much we can do, no matter the incentives. > Option 2 means that packages that explicitly request the ffmpeg package by > name will not work without RPM Fusion. This avoids the short-term pain I > mentioned in option 1, but eliminates our incentive to work on dynamically > expanding codec availability in the package in Fedora. I'd go with option 2. ffmpeg in RPM Fusion was "first" and is the fully featured package. I'd be happy to co-maintain ffmpeg-free in Fedora, too. (In reply to Andreas Schneider from comment #20) > (In reply to leigh scott from comment #16) [...] > > You can't enable fdk without making the ffmpeg package unredistributabe, > > fdk-acc-free doesn't mitigate it. > > > > EXTERNAL_LIBRARY_NONFREE_LIST=" > > decklink > > libfdk_aac > > libtls > > > > > > --enable-nonfree allow use of nonfree code, the resulting libs > > and binaries will be unredistributable [no] That needs to be patched considering RH legal approved it: diff -up ffmpeg-5.0/configure.orig ffmpeg-5.0/configure --- ffmpeg-5.0/configure.orig 2022-01-17 14:41:41.369212587 +0100 +++ ffmpeg-5.0/configure 2022-01-20 23:43:27.370353154 +0100 @@ -1783,7 +1783,6 @@ EXTERNAL_LIBRARY_GPL_LIST=" EXTERNAL_LIBRARY_NONFREE_LIST=" decklink - libfdk_aac libtls " @@ -1822,6 +1821,7 @@ EXTERNAL_LIBRARY_LIST=" libdav1d libdc1394 libdrm + libfdk_aac libflite libfontconfig libfreetype > We could also dlopen() it. Would that work? There's no legal difference as far as I understand (IANAL) and I don't like carrying non-upstream patches forever. I'll post more comments shortly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2051008 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
